Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions in CI checks #635

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Update versions in CI checks #635

merged 1 commit into from
Mar 17, 2022

Conversation

codificat
Copy link
Member

Related Issues and Dependencies

mypy checks are currently failing in #616

I'm not really sure if this update will fix that, but it should not hurt either

This introduces a breaking change

  • No

This Pull Request implements

Update the versions of the images used for prow CI checks.

Update the versions of the pre-commit checks and merge two redundant entries

@codificat
Update versions in CI checks
f8ffc3f 
Signed-off-by: Pep Turró Mauri <[email protected]>
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2022
@sesheta
Copy link
Member

sesheta commented Mar 17, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sesheta after the PR has been reviewed.
You can assign the PR to them by writing /assign @sesheta in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codificat codificat mentioned this pull request Mar 17, 2022
Closed
2 tasks
@sesheta
Copy link
Member

sesheta commented Mar 17, 2022

@codificat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/mypy f8ffc3f link true /test thoth-mypy-py38

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harshad16 harshad16 merged commit 203d096 into thoth-station:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 Awaiting requested review from harshad16

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codificat @sesheta @harshad16